test_runner: allow subtest filtering via --test-name-pattern #46883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
ljharb
reviewed
Feb 28, 2023
richiemccoll
force-pushed
the
test-runner/subtest-filtering
branch
from
66a9f16
to
8a16058
Compare
ljharb
reviewed
Feb 28, 2023
| // eslint-disable-next-line no-use-before-define | ||
| this instanceof TestHook || | ||
| ArrayPrototypeSome(testNamePatterns, (re) => { | ||
| const scopedTestNamePatterns = StringPrototypeSplit(re, '>'); |
There was a problem hiding this comment.
i think this may need to use RegExpPrototypeSymbolSplit
|
what's the status on this one? |
|
@richiemccoll are you still working on this, or should we close it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46728.
This PR allows users to filter subtests via the
--test-name-patterncli flag. This will only run the subtests with a name that matches the specified, scoped regex. Scoping tests can be done via the>character, as suggested here.